Use Regexp option predicate from rubocop-ast

Introduced in rubocop/rubocop-ast#20
owst · Jun 4, 2020 · 513811b · 513811b
1 parent b52b6e4
commit 513811b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 25 deletions.
diff --git a/lib/rubocop.rb b/lib/rubocop.rb
@@ -98,7 +98,6 @@
 require_relative 'rubocop/cop/mixin/preceding_following_alignment'
 require_relative 'rubocop/cop/mixin/preferred_delimiters'
 require_relative 'rubocop/cop/mixin/rational_literal'
-require_relative 'rubocop/cop/mixin/regexp_literal_help'
 require_relative 'rubocop/cop/mixin/rescue_node'
 require_relative 'rubocop/cop/mixin/safe_assignment'
 require_relative 'rubocop/cop/mixin/space_after_punctuation'

diff --git a/lib/rubocop/cop/mixin/regexp_literal_help.rb b/lib/rubocop/cop/mixin/regexp_literal_help.rb
diff --git a/lib/rubocop/cop/style/redundant_regexp_character_class.rb b/lib/rubocop/cop/style/redundant_regexp_character_class.rb
@@ -23,7 +23,6 @@ module Style
       #   r = /[ab]/
       class RedundantRegexpCharacterClass < Cop
         include MatchRange
-        include RegexpLiteralHelp
 
         MSG_REDUNDANT_CHARACTER_CLASS = 'Redundant single-element character class, ' \
         '`%<char_class>s` can be replaced with `%<element>s`.'
@@ -44,7 +43,7 @@ class RedundantRegexpCharacterClass < Cop
 
         def on_regexp(node)
           each_redundant_character_class(node) do |loc|
-            next if whitespace_in_free_space_mode?(node, loc)
+            next if whitespace_in_extended_regexp?(node, loc)
 
             add_offense(
               node,
@@ -78,8 +77,8 @@ def without_character_class(loc)
           loc.source[1..-2]
         end
 
-        def whitespace_in_free_space_mode?(node, loc)
-          return false unless freespace_mode_regexp?(node)
+        def whitespace_in_extended_regexp?(node, loc)
+          return false unless node.extended?
 
           /\[\s\]/.match?(loc.source)
         end

diff --git a/lib/rubocop/cop/style/redundant_regexp_escape.rb b/lib/rubocop/cop/style/redundant_regexp_escape.rb
@@ -31,7 +31,6 @@ module Style
       #   /[+\-]\d/
       class RedundantRegexpEscape < Cop
         include RangeHelp
-        include RegexpLiteralHelp
 
         MSG_REDUNDANT_ESCAPE = 'Redundant escape inside regexp literal'
 
@@ -111,12 +110,10 @@ def escape_range_at_index(node, index)
         end
 
         def pattern_source(node)
-          freespace_mode = freespace_mode_regexp?(node)
-
           node.children.reject(&:regopt_type?).map do |child|
             source = child.source
 
-            if freespace_mode
+            if node.extended?
               # Remove comments to avoid misleading results
               source.sub(/(?<!\\)#.*/, '')
             else