Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn on exhaustive deps #18

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feat: warn on exhaustive deps #18

merged 1 commit into from
Jan 12, 2024

Conversation

stefvw93
Copy link
Collaborator

react-hooks/exhaustive-deps put on "warn" mode by default (not error)

  • generally useful for bug-prone lifecycle
  • reports false positives
  • urges you to create infinite update cycles with useEffect
  • does not understand delicate code logic

@stefvw93 stefvw93 requested a review from barisbora January 12, 2024 11:00
@stefvw93 stefvw93 merged commit 5afa4e1 into master Jan 12, 2024
1 check passed
@stefvw93 stefvw93 deleted the feature/disable-react-exhaustive-deps branch January 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasowow thomasowow thomasowow approved these changes

@barisbora barisbora Awaiting requested review from barisbora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefvw93 @thomasowow