Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use vite for package bundling and allow treeshaking #109

Merged
merged 11 commits into from
Dec 1, 2023
Merged

chore: use vite for package bundling and allow treeshaking #109

merged 11 commits into from
Dec 1, 2023

Conversation

Sjoertjuh
Copy link
Contributor

Features:

  • Use Vite for building
    • This allows for easier treeshaking ability
  • Use Vitest for testing
    • Faster (in most cases)
  • Output sourcemaps
    • Better developer experience

@Sjoertjuh Sjoertjuh requested a review from thomasowow December 1, 2023 13:18
thomasowow
thomasowow approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@thomasowow thomasowow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this in a real situation?

@Sjoertjuh Sjoertjuh marked this pull request as ready for review December 1, 2023 14:06
@Sjoertjuh
Copy link
Contributor Author

@thomasowow I tried it on an existing project using the yarn link command, and everything seems to work

@Sjoertjuh Sjoertjuh merged commit 852130d into master Dec 1, 2023
1 check passed
@Sjoertjuh Sjoertjuh deleted the chore/treeshaking branch December 1, 2023 14:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🎉 This PR is included in version 1.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasowow thomasowow thomasowow approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sjoertjuh @thomasowow