Merge pull request #105 from owowagency/fix/allow-custom-variants

owowagency · Nov 22, 2023 · 27b476c · 27b476c
2 parents c98b964 + ac56918
commit 27b476c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 27 deletions.
diff --git a/src/composables/useVariant/index.ts b/src/composables/useVariant/index.ts
@@ -3,7 +3,7 @@ import useStringTemplate from '@/composables/useStringTemplate';
 
 export const variants = ['primary', 'secondary', 'success', 'danger', 'warning', 'info', 'light', 'dark', 'link'] as const;
 
-export type Variant = typeof variants[number];
+export type Variant = typeof variants[number] | string;
 
 export default (variant: MaybeRef<Variant>, classTemplate: MaybeRef<string>) => {
     const {templatedString} = useStringTemplate(classTemplate, variant);
@@ -15,7 +15,6 @@ export const variantProp = (defaultValue: Variant | '' | undefined = 'primary')
     return {
         type: String as PropType<Variant>,
         default: defaultValue,
-        validator: (v?: Variant) => v ? variants.includes(v) : true,
     };
 };
 

diff --git a/src/composables/useVariant/useVariant.test.ts b/src/composables/useVariant/useVariant.test.ts
@@ -1,28 +1,4 @@
-import useVariant, {variantProp, variantProps, variants} from '.';
-
-describe('variantProps', () => {
-    describe('variant', () => {
-        variants.forEach((s) => {
-            it(`passes validation with ${s}`, () => {
-                const result = variantProps.variant.validator(s);
-
-                expect(result).toBe(true);
-            });
-        });
-
-        it('passes validation with empty value', () => {
-            const result = variantProps.variant.validator(undefined);
-
-            expect(result).toBe(true);
-        });
-
-        it('passes validation with a non variant', () => {
-            const result = variantProps.variant.validator('non-variant');
-
-            expect(result).toBe(false);
-        });
-    });
-});
+import useVariant, {variantProp} from '.';
 
 describe('variantProp', () => {
     it('sets the default value', () => {