Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History tab shown although disabled by default #833

Closed
lostfocus opened this issue Feb 13, 2025 · 6 comments
Closed

History tab shown although disabled by default #833

lostfocus opened this issue Feb 13, 2025 · 6 comments

Comments

@lostfocus
Copy link

I just upgraded the app and suddenly I have this tab - it seems like it's not doing anything? I couldn't find anything in the booklet or in the issues.

Version 18.3.1 on iOS 18.3 on an iPhone 15 Pro Max

Image

@jpmens
Copy link
Member

jpmens commented Feb 14, 2025

It's been there for many releases and shows enter/leave events

@lostfocus
Copy link
Author

lostfocus commented Feb 14, 2025

I dug deeper into the settings/booklet and I think now I know why I haven't seen it before:

maxHistory Number of notifications to store historically. Zero (0) means no notifications are stored and history tab is hidden. Defaults to zero. (iOS/integer)

I have set this to 0 and still saw the tab yesterday. I just checked again and this morning the tab was gone.

@ckrey
Copy link
Member

ckrey commented Feb 14, 2025

Thanks for spotting this.

If maxHistory is set to zero, the screen initially shows the History tab. If the value is later changed or the Settings screen is opened, the tab disappears.

@ckrey ckrey added the bug label Feb 14, 2025
@ckrey ckrey changed the title History? History tab shown although disabled by default Feb 14, 2025
@ckrey ckrey added the fixed label Feb 16, 2025
@ckrey
Copy link
Member

ckrey commented Feb 19, 2025

Version 18.3.2 beta is available in Testflight https://testflight.apple.com/join/k2iqRtjH

@lostfocus
Copy link
Author

Looks good to me!

@ckrey
Copy link
Member

ckrey commented Feb 19, 2025

Thanks for re-testing

@ckrey ckrey closed this as completed Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants