-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker install #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sharkoz,
Thanks a lot for this PR! 😃
I'm confident it will just work, in fact I'm already using Docker with this project - but in a much more hackish way, and without a custom Dockerfile.
I made a few suggestions, most importantly renaming the (misleading) SERVER_URL
environment variable to SERVER_HOST
, as well as some formatting changes.
The nginx config might need some updates when I finally release v2 (it's a single page application), but let's not worry about that. I'll look into releasing on Dockerhub (never did that before), My preferred solution would be moving this project over to the @owntracks organisation and use their Docker Hub namespace for the package. 🤔
I'll create a separate discussion issue for this.
Co-Authored-By: Linus Groh <[email protected]>
All done :) For starters, publishing yourself on docker hub is very easy, you create an account, link it to your github account, and then you create a new repository on docker hub, link it to this one on github, and configure it to 'autobuild'. Now every commit to master will build automatically a new image on docker hub ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more small changes please and I think we can merge this!
Co-Authored-By: Linus Groh <[email protected]>
Co-Authored-By: Linus Groh <[email protected]>
Is everything OK now ? 😉 |
Almost - please see #7 (comment) |
Nice work, this will be a very useful addition 👍 |
@jpmens can we set up builds for |
@linusg we can, whereby “we” means somebody tells me what buttons to press and I press the buttons. :) I’ve done it once before but have forgotten how it works. If @sharkoz, say, guides me (a micro howto would be wonderful), I’ll gladly attend to it, but it might take until Monday until I do so as I’m off to EuroBSDCon tomorrow morning. |
@jpmens , once this is merged, you have to go on docker hub, login using the owntracks account (https://hub.docker.com/u/owntracks) , and then go into the menu 'repositories'.
This way @linusg can create a tag on github and it will automatically create a tagged image with the same name. Afterwards, you can edit the README to use the name of the image you created instead of the name of my image (cosme/owntracks-ui) |
@sharkoz thank you for what I thought were very clear instructions, but I appear to be doing something incorrectly, as when clicking on the Github logo, I don't get anything other than "Customize build settings". Can you see where I've gone wrong from the screenshot? |
Here is how it should look like. Maybe see if you have an adblocker or
something like this ?
![Screenshot_20190924-133422](https://user-images.githubusercontent.com/4211938/65508484-9d971980-ded0-11e9-9e4b-0819f853f131.jpg)
Le mar. 24 sept. 2019 à 13:19, JP Mens <[email protected]> a écrit :
… @sharkoz <https://github.com/sharkoz> thank you for what I thought were
very clear instructions, but I appear to be doing something incorrectly, as
when clicking on the Github logo, I don't get anything other than
"Customize build settings".
[image: jmbp-5553]
<https://user-images.githubusercontent.com/60706/65507281-e1d4ea80-decd-11e9-8cb8-7163b13ea580.png>
Can you see where I've gone wrong from the screenshot?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=ABAEJYXVVBLN7TD3Q25ILH3QLHZTVA5CNFSM4ITDVN32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7OAH5I#issuecomment-534512629>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAEJYXYTTYGWNYFTPELRT3QLHZTVANCNFSM4ITDVN3Q>
.
|
(attachments sent in via email aren't shown in Github issues :-) |
Got it, thank you. I had to re-link Github, and I'm now completing your instructions. |
@linusg, over to you, I think. :-) |
Awesome, let's see if this works. Thanks again for the PR @sharkoz! |
Creates a docker image for easy deployment.
This is deployable to docker hub, as seen here :
https://cloud.docker.com/u/cosme/repository/docker/cosme/owntracks-ui
You should of course create your own repo from docker hub and edit the readme accordingly to give the proper image name.