Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Vue to not assume it's on the web root #47

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Configure Vue to not assume it's on the web root #47

merged 1 commit into from
Dec 29, 2020

Conversation

growse
Copy link
Contributor

@growse growse commented Dec 29, 2020

Not sure if this will have much knock-on effects, but when trying to run the frontend on a non-root path, I noticed that the generated output assumes that config etc are all available on /, which isn't necessarily the case.

Setting publicPath to be "" seems to make it try and resolve dependencies relative to index.html, which feels like the right thing to do.

@linusg
Copy link
Member

linusg commented Dec 29, 2020

tested it locally and it breaks the map as its route is /. We might have to add another config option similar to api.baseUrl as we don't know it during build time (anymore) but have to configure the router correctly:

base: process.env.BASE_URL,

@linusg linusg changed the title Configure vue to not assume it's on the web root Configure Vue to not assume it's on the web root Dec 29, 2020
@linusg linusg merged commit 696706b into owntracks:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants