Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep both conflict #9915

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

jacob-nv
Copy link
Contributor

@jacob-nv jacob-nv commented Nov 7, 2023

Description

In case of /folder/folder where result should be /folder/folder (1) to resolve conflict, regex updated URL to /folder(1)/folder

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jacob-nv jacob-nv requested a review from JammingBen November 7, 2023 11:43
Copy link

update-docs bot commented Nov 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Since this is not a recent regression, please also add a changelog item. You can keep it high-level though, no need to go into too much technical detail.

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 24579e3 into owncloud:master Nov 9, 2023
4 checks passed
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* keep both conflict fix

* keep both conflict cleanup

* added changelog, keep both conflict

* fixed changelog, keep both conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Keep both" conflict handling fails in certain edge cases
2 participants