Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "File type" filter Chip #9912

Merged
merged 21 commits into from
Nov 14, 2023
Merged

Add "File type" filter Chip #9912

merged 21 commits into from
Nov 14, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Nov 6, 2023 •
edited
Loading

Description

The capability for mimeTypes needs to be enabled OR find unref(modifiedDateCapability).enabled and add a !
Backend is not on master yet, needs Romans PR (owncloud/ocis#7602) as backend
See #9780

Related Issue

Screenshots (if appropriate):

Screenshot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@lookacat lookacat marked this pull request as ready for review November 8, 2023 15:10
AlexAndBear
AlexAndBear requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'd love to have some tests if possible

JammingBen
JammingBen reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add q_mimeTypes here to ensure that the filter stays active after closing an editor on the search result page:

web/packages/web-pkg/src/router/common.ts

Line 31 in 7e5340a

'term',

packages/web-app-files/src/components/Search/List.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/Search/List.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/Search/List.vue Outdated Show resolved Hide resolved
@lookacat
Copy link
Contributor Author

lookacat commented Nov 9, 2023

I addressed most issues, i didn't rename the capability yet because it would break the whole thing. I'll have to wait until the linked PR (in the description) from Roman is changed.
Tests will follow

@lookacat
Copy link
Contributor Author

e2e tests added, but will only work if romans PR is on master

JammingBen
JammingBen approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lookacat lookacat enabled auto-merge (squash) November 14, 2023 09:45
kulmann
kulmann reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one weird issue:

  • open file type filter
  • select "Document" and "Folder"
  • use text filter in the dropdown with whatever string and delete it again
  • selected items (Document and Folder) are re-arranged to the top of the list

Fine to solve this in a followup if this is an issue of the filter dropdown (that's what I suspect). Please open a bug issue after investigation.

@lookacat lookacat disabled auto-merge November 14, 2023 10:23
@lookacat lookacat mentioned this pull request Nov 14, 2023
Closed
@lookacat lookacat force-pushed the 7432-filetype-filterchip branch from e235369 to 88c161f Compare November 14, 2023 11:50
@lookacat lookacat force-pushed the 7432-filetype-filterchip branch from 3705d10 to 7ce522c Compare November 14, 2023 14:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.5% 73.5% Coverage
0.0% 0.0% Duplication

@lookacat lookacat enabled auto-merge (squash) November 14, 2023 16:02
@lookacat lookacat requested a review from kulmann November 14, 2023 16:03
@lookacat
Copy link
Contributor Author

@kulmann please rereview, followup issue is created and im already on it #9938

kulmann
kulmann approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 😍

@lookacat lookacat merged commit ed8f2fd into master Nov 14, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 7432-filetype-filterchip branch November 14, 2023 20:25
@JammingBen JammingBen mentioned this pull request Nov 16, 2023
Merged
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear @JammingBen
Add "File type" filter Chip (#9912)
8c756bb 
* Implement basic ui filter construct

* Implement doctype icons

* Add changelog

* Refactor using capabilities for filetypes

* Make filter work

* Add check for capability

* Fix typescript error

* Address PR issues

* rename to mediatype

* Update changelog

* add missing mediatype renames

* Fix renaming issue

* WIP e2e

* WIP e2e

* Implement basic mediaType filter e2e test

* Add more e2e steps

* logout user before finishing test scenario

Co-authored-by: Jannik Stehle <[email protected]>

* Update ocis commit id

* Adjust ocis commit id

* Adjust commit id

* Update changelog

---------

Co-authored-by: Jan <[email protected]>
Co-authored-by: Jannik Stehle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Add "File type" filter Chip
4 participants
@lookacat @kulmann @AlexAndBear @JammingBen