Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut url followup #9908

Merged
merged 25 commits into from
Nov 8, 2023
Merged

Shortcut url followup #9908

merged 25 commits into from
Nov 8, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 2, 2023 •
edited
Loading

Description

Enhancement: Create shortcuts

We've added a new functionality to add to shortcuts to web, those can be created via the "+ New" context menu.
Users can enter URLs or pick a file via the drop down menu and create a '.url' file.

'.url' files can be opened via web or downloaded and opened on the desktop.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Nov 2, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann November 4, 2023 10:22
@AlexAndBear AlexAndBear requested a review from lookacat November 6, 2023 09:48
lookacat
lookacat approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 , but would be cool if you link the original issue in the description :)

@AlexAndBear AlexAndBear marked this pull request as draft November 6, 2023 11:17
@AlexAndBear AlexAndBear marked this pull request as ready for review November 6, 2023 12:47
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Nov 6, 2023 •
edited
Loading

@kulmann refactored search with @dschmidt, have phun with review ❤️

🤡

kulmann
kulmann requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah dude. The UX feels so flawless. 💪 Found one issue: we didn't think about public links during concepting... 🤦 at least the search part should be disabled (don't even make the requests!) if in a public link...

packages/web-pkg/src/components/CreateShortcutModal.vue Show resolved Hide resolved
kulmann
kulmann reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more UX thing... when you do a right click on a .url file, the action for following the url is sorted below the sharing options. I would have expected it at the very top (like every other file handler, e.g. Open in TextEditor). Not sure though, if that's easily possible in the current state of web. For me also ok if you just open a followup issue.

@kulmann kulmann mentioned this pull request Nov 7, 2023
Open
@kulmann
Copy link
Member

kulmann commented Nov 7, 2023

Aaaand another conceptual issue, but that's definitely something for a followup: #9917

@AlexAndBear
Copy link
Contributor Author

One more UX thing... when you do a right click on a .url file, the action for following the url is sorted below the sharing options. I would have expected it at the very top (like every other file handler, e.g. Open in TextEditor). Not sure though, if that's easily possible in the current state of web. For me also ok if you just open a followup issue.

Not an issue to implement that ;)

@AlexAndBear AlexAndBear requested a review from kulmann November 7, 2023 17:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

75.7% 75.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

kulmann
kulmann approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@AlexAndBear AlexAndBear merged commit ad51cdc into master Nov 8, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/9796-2 branch November 8, 2023 11:15
lookacat
lookacat reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing found

packages/web-pkg/src/components/Search/ResourcePreview.vue Show resolved Hide resolved
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Shortcut url followup (#9908)
d00fbcc 
* Shortcut url followup 2

* open in same window if is ocis uri

* add more tests

* add drop

* Duplicate filename handling

* Confirm modal with enter button

* Add https in front of uri if missing

* Fix file extension placement

* Add unit test

* Don't throw

* Fix styling

* Add search and fix unit tests

* Add more tests

* Change code comment

* Add changelog item

* Don't scope scss

* Kick oc10 leftover

* Fix space icon not shown

* Refactor search

* Fix unit tests

* Refactor tests

* React on code review

* React on code review

* Fix display Link to a file, shown if no search results

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] File action for .url files [web] Create Shortcuts: Resource [web] Create Shortcuts: webpage
5 participants
@AlexAndBear @kulmann @dschmidt @lookacat @JammingBen