-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize "New" menu | Add default extension to menu item #9906
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM, please add a changelog item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see two separator lines if there are no apps from the app provider... although the code doesn't read like that. o_O could you check that please?
yes will check it |
4641c4f
to
c4d6a06
Compare
@kulmann should be good to go now, fixed the line issue and added the url shortcut from rebase and unittests |
Kudos, SonarCloud Quality Gate passed! |
* Organize New-Menu / add extensions * WIP * Fix styling add extension * Only show extension if setting is enabled, Update snapshots * Remove inline style * Add changelog item * Adjust min-width depending on file extensions shown * Fix double seperator line * Add unittests * Fix typo * Move url shortcut to bottom position in menu
Description
See #9846
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: