Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add actions into the embed mode #9841

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Oct 23, 2023

Description

Add Cancel, Share and Select action into the files app available only when the mode is set to embed. All actions are ported below the app container.

Related Issue

Motivation and Context

These new actions allow external developers to consume resources or links from within the embedded web ui.

How Has This Been Tested?

  • test environment: run the embed mode locally
  • test case 1: check for cancel event
  • test case 2: select resources and check for select event
  • test case 3: select resources and check for share event

Screenshots (if appropriate):

localhost_9200_oidc-callback_code=2tkxvNouXXnbP5XMPktTt3BFC-bE3Z4O scope=profile%20email%20openid session_state=8840316b1888469a5680edb38092be53e07838ea1626d2291817adba119b8e1e gX01Vko_u01UXklokhxBaizwML7Ukr70bJ5vROXRycU state=64d3cfa3ba804

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 23, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@LukasHirt LukasHirt marked this pull request as ready for review October 23, 2023 09:08
@LukasHirt
Copy link
Collaborator Author

@JammingBen @dschmidt ping for review 🙏

@LukasHirt
Copy link
Collaborator Author

I had to update snapshots due to the change in files wrapper... the change is kept in a separate commit to spot it more easily

@LukasHirt
Copy link
Collaborator Author

The test failure is strange... the test passes when the portal in files wrapper is commented out but looking in the code, I do not see anything that would be causing recurring calls.

@LukasHirt
Copy link
Collaborator Author

The test failure is strange... the test passes when the portal in files wrapper is commented out but looking in the code, I do not see anything that would be causing recurring calls.

Found it together with Jannik... we need to stub out the portal component as it seems to cause troubles in tests. We are not testing portal itself in those tests so it is fine to stub it out.

@LukasHirt LukasHirt requested a review from JammingBen October 24, 2023 08:35
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

You probably need to stub portal in GenericTrash.spec.ts as well for the unit tests to go green.

@LukasHirt
Copy link
Collaborator Author

You probably need to stub portal in GenericTrash.spec.ts as well for the unit tests to go green.

You're right, thanks!... it should pass now

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

76.2% 76.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 2deeae2 into owncloud:master Oct 24, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Oct 24, 2023
feat: add actions into the embed mode
@LukasHirt LukasHirt deleted the feat/embed-actions branch October 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants