Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added e2e test for show password, copy password and generate password buttons #9820

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[tests-only][full-ci]added e2e test for show password, copy password and generate password buttons #9820

merged 1 commit into from
Oct 20, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Oct 17, 2023 •
edited
Loading

Description

In this PR, added the step implementation for new buttons,

  • Show/Hide Password
  • Copy Password
  • Generate Password

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • e2e tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya marked this pull request as draft October 17, 2023 09:09
@PrajwolAmatya PrajwolAmatya changed the title [tests-only][full-ci]dded e2e test for show password, copy password and generate password… [tests-only][full-ci]dded e2e test for show password, copy password and generate password buttons Oct 17, 2023
@PrajwolAmatya PrajwolAmatya self-assigned this Oct 17, 2023
@PrajwolAmatya PrajwolAmatya mentioned this pull request Oct 17, 2023
Closed
2 tasks
@PrajwolAmatya PrajwolAmatya force-pushed the implement-steps-for-new-buttons branch 2 times, most recently from 44c998d to d1acf07 Compare October 17, 2023 11:09
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review October 18, 2023 03:22
@SwikritiT SwikritiT changed the title [tests-only][full-ci]dded e2e test for show password, copy password and generate password buttons [tests-only][full-ci]added e2e test for show password, copy password and generate password buttons Oct 18, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the implement-steps-for-new-buttons branch from d1acf07 to 1ec1b0b Compare October 19, 2023 06:08
@PrajwolAmatya PrajwolAmatya force-pushed the implement-steps-for-new-buttons branch from 1ec1b0b to 8106b48 Compare October 19, 2023 09:02
@PrajwolAmatya PrajwolAmatya requested a review from saw-jan October 19, 2023 09:19
@PrajwolAmatya PrajwolAmatya force-pushed the implement-steps-for-new-buttons branch from 8106b48 to 7de1473 Compare October 20, 2023 05:04
@PrajwolAmatya PrajwolAmatya force-pushed the implement-steps-for-new-buttons branch from 7de1473 to 88284f3 Compare October 20, 2023 05:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ScharfViktor
ScharfViktor approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍
thank you

saw-jan
saw-jan approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan saw-jan merged commit 0332b24 into master Oct 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the implement-steps-for-new-buttons branch October 20, 2023 07:21
LukasHirt pushed a commit to LukasHirt/web that referenced this pull request Oct 25, 2023
@PrajwolAmatya @LukasHirt
added e2e test for show password, copy password and generate password…
8e1a52b 
… buttons (owncloud#9820)
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@PrajwolAmatya @AlexAndBear
added e2e test for show password, copy password and generate password…
82c2eff 
… buttons (#9820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@SagarGi SagarGi Awaiting requested review from SagarGi

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PrajwolAmatya @SwikritiT @SagarGi @saw-jan @ScharfViktor