Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add permission checks for creating shares and favorites #9810

Merged
merged 6 commits into from
Nov 14, 2023
Merged

feat: add permission checks for creating shares and favorites #9810

merged 6 commits into from
Nov 14, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 16, 2023 •
edited
Loading

Description

Add and enforce permission checks for creating shares and favorites. Note that you need a current oCIS docker image for testing.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen force-pushed the share-and-favorite-permission-checks branch from 331daf9 to 4e8b6c9 Compare October 20, 2023 11:19
@JammingBen JammingBen force-pushed the share-and-favorite-permission-checks branch from 4e8b6c9 to ef4766b Compare November 13, 2023 14:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

45.8% 45.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@owncloud owncloud deleted a comment from update-docs bot Nov 13, 2023
@JammingBen JammingBen marked this pull request as ready for review November 14, 2023 07:48
kulmann
kulmann approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JammingBen JammingBen merged commit 62fb73c into master Nov 14, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the share-and-favorite-permission-checks branch November 14, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @kulmann @AlexAndBear