-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate file editors application menu #9809
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
a0d3f7a
to
ae84c52
Compare
@@ -21,8 +21,9 @@ export class Application { | |||
} | |||
|
|||
async open({ name }: { name: string }): Promise<void> { | |||
await this.#page.waitForTimeout(1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might need to find a better way
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue
Outdated
Show resolved
Hide resolved
8e67539
to
527ec1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Few minor things I've found, also:
- The parent folder name seems to be wrong for files inside the root of a received share
- Opening the preview app throws console errors, closing the app breaks Web
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue
Outdated
Show resolved
Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue
Outdated
Show resolved
Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue
Outdated
Show resolved
Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue
Outdated
Show resolved
Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue
Outdated
Show resolved
Hide resolved
Both have been fixed, but we won't show the parentFolderLink in the AppTopBar if the file is a received share due to the original shared folder name is not resolvable for now. |
308f839
to
6daa77e
Compare
SonarCloud Quality Gate failed. 0 Bugs 48.2% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
* Integrate file editors in application menu
* Integrate file editors in application menu
Description
See #9807
Related Issue
Screenshots:
Types of changes
Checklist:
Open tasks: