Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: search provider registration #9794

Merged
merged 1 commit into from
Oct 12, 2023
Merged

refactor: search provider registration #9794

merged 1 commit into from
Oct 12, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 11, 2023 •
edited
Loading

Description

Gets rid of the search provider registration via event bus. Instead, search providers are now being registered as SearchExtension via our extension registry.

Works towards #9264.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@update-docs
Copy link

update-docs bot commented Oct 11, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

57.6% 57.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen marked this pull request as ready for review October 12, 2023 10:59
AlexAndBear
AlexAndBear approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super b

@JammingBen JammingBen merged commit a3f6e8c into master Oct 12, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-search branch October 12, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@grimmoc grimmoc Awaiting requested review from grimmoc

Assignees

@dschmidt dschmidt

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @AlexAndBear @dschmidt