Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create .space folder if removed #9793

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Conversation

jacob-nv
Copy link
Contributor

Description

If image is being updated, files are checked for '.space' existing. If the folder is missing, it will be created with default readme.md

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jacob-nv jacob-nv requested a review from JammingBen October 10, 2023 17:39
@jacob-nv jacob-nv self-assigned this Oct 10, 2023
@update-docs
Copy link

update-docs bot commented Oct 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jacob-nv jacob-nv requested a review from JammingBen October 11, 2023 14:26
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Please add a changelog item (type enhancement), then this is good to go.

@JammingBen
Copy link
Contributor

Code LGTM, one unit test is failing though: https://drone.owncloud.com/owncloud/web/39514/9/5

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 43dca38 into owncloud:master Oct 20, 2023
2 checks passed
LukasHirt pushed a commit to LukasHirt/web that referenced this pull request Oct 25, 2023
* create .space folder if removed

* space folder check by api, updating drive to refresh readme

* bugfix .space folder changelog

* creating space config folder in composable

* rename createDefaultConfigFolder to createDefaultMetaFolder

* useCreateSpace fix
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* create .space folder if removed

* space folder check by api, updating drive to refresh readme

* bugfix .space folder changelog

* creating space config folder in composable

* rename createDefaultConfigFolder to createDefaultMetaFolder

* useCreateSpace fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for .space folder when updating image or readme for a space
3 participants