Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inject store in webdav abstraction layer #9743

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

JammingBen
Copy link
Contributor

Description

This ensures the abstraction layer has access to global settings like configuration, capabilities or user information. It will also be needed in the future when the SDK is being replaced.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

This ensures the abstraction layer has access to global settings like configuration, capabilities or user information. It will also be needed in the future when the SDK is being replaced.
@JammingBen JammingBen self-assigned this Sep 28, 2023
@update-docs
Copy link

update-docs bot commented Sep 28, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement 👍🏼

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

16.7% 16.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen merged commit 49764fc into master Sep 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the inject-store-in-webdav-abstraction branch September 28, 2023 13:13
ownclouders pushed a commit that referenced this pull request Sep 28, 2023
…tion

refactor: inject store in webdav abstraction layer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants