Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username cannot include special characters #9703

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

jacob-nv
Copy link
Contributor

Description

Added regex validation based on https://github.com/owncloud/ocis/blob/8cbf261568197a5494931357b5318d57b7134ae9/services/graph/pkg/service/v0/users.go#L742 to user creation

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is actually changelog-worthy, please add one 🙂

@jacob-nv jacob-nv requested a review from JammingBen September 20, 2023 13:49
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen enabled auto-merge (squash) September 20, 2023 14:20
@JammingBen JammingBen merged commit 297bf70 into owncloud:master Sep 20, 2023
2 checks passed
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
* Username cannot include special characters

* user name validation, changelog & comments

* user name validation, comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create User fails
2 participants