Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checking for disabled keyboard actions in text-editor app #9699

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Skip checking for disabled keyboard actions in text-editor app #9699

merged 3 commits into from
Sep 18, 2023

Conversation

pascalwengerter
Copy link
Contributor

JammingBen
JammingBen reviewed Sep 18, 2023
View reviewed changes
packages/web-pkg/src/components/AppTemplates/AppWrapper.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/composables/keyboardActions/useKeyboardActions.ts Outdated
@@ -65,12 +65,12 @@ const areCustomKeyBindingsDisabled = () => {
return isTextSelected
}

export const useKeyboardActions = (): KeyboardActions => {
export const useKeyboardActions = (skipDisabledKeyBindingsCheck?: boolean): KeyboardActions => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer passing an object here. It's easier to handle with booleans since you're not only passing true or false into the function then.

JammingBen
JammingBen approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 4 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen merged commit b6041ce into owncloud:master Sep 18, 2023
1 of 2 checks passed
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@pascalwengerter @AlexAndBear
Skip checking for disabled keyboard actions in text-editor app (#9699)
3b87470 
* Skip checking for disabled keyboard actions in text-editor app

* Implement feedback from code review

* Fix unit test
@pascalwengerter pascalwengerter deleted the bugfix/9695 branch January 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save keyboard shortcuts not working
2 participants
@pascalwengerter @JammingBen