-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Discard new tab wait for file creation and public link open #9677
Merged
ScharfViktor
merged 1 commit into
master
from
fix/nightly_hard_failure_for_officesuites_tests
Sep 8, 2023
Merged
[tests-only][full-ci]Discard new tab wait for file creation and public link open #9677
ScharfViktor
merged 1 commit into
master
from
fix/nightly_hard_failure_for_officesuites_tests
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
SagarGi
force-pushed
the
fix/nightly_hard_failure_for_officesuites_tests
branch
2 times, most recently
from
September 8, 2023 07:00
b790a58
to
3056d65
Compare
SagarGi
requested review from
phil-davis,
saw-jan,
grgprarup,
PrajwolAmatya,
ScharfViktor and
SwikritiT
September 8, 2023 07:12
SwikritiT
changed the title
[test-only][full-ci]Discard new tab wait for file creation and public link open
[tests-only][full-ci]Discard new tab wait for file creation and public link open
Sep 8, 2023
saw-jan
reviewed
Sep 8, 2023
SagarGi
force-pushed
the
fix/nightly_hard_failure_for_officesuites_tests
branch
from
September 8, 2023 08:36
3056d65
to
b74236d
Compare
saw-jan
reviewed
Sep 8, 2023
saw-jan
reviewed
Sep 8, 2023
SagarGi
force-pushed
the
fix/nightly_hard_failure_for_officesuites_tests
branch
from
September 8, 2023 09:56
b74236d
to
453352a
Compare
saw-jan
approved these changes
Sep 8, 2023
ScharfViktor
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SagarGi
force-pushed
the
fix/nightly_hard_failure_for_officesuites_tests
branch
from
September 8, 2023 11:01
453352a
to
4a2e024
Compare
SagarGi
force-pushed
the
fix/nightly_hard_failure_for_officesuites_tests
branch
from
September 8, 2023 11:06
4a2e024
to
82d2c70
Compare
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
fix/nightly_hard_failure_for_officesuites_tests
branch
September 8, 2023 11:42
ownclouders
pushed a commit
that referenced
this pull request
Sep 10, 2023
ownclouders
pushed a commit
that referenced
this pull request
Sep 11, 2023
ownclouders
pushed a commit
that referenced
this pull request
Sep 11, 2023
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hard failure was due to previously web
master
while creating files would open then office suites files into a new tab but now all those files are created and opened in the same tab. So This PR adjusts the test code for it. but in webstable-7.1
it is passing since it opens the new tab during the file creation.Related issue:
#9674