Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Discard new tab wait for file creation and public link open #9677

Merged

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 8, 2023

Description

The hard failure was due to previously web master while creating files would open then office suites files into a new tab but now all those files are created and opened in the same tab. So This PR adjusts the test code for it. but in web stable-7.1 it is passing since it opens the new tab during the file creation.

Related issue:

#9674

@update-docs
Copy link

update-docs bot commented Sep 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@SagarGi SagarGi self-assigned this Sep 8, 2023
@SagarGi SagarGi added the QA:team label Sep 8, 2023
@SagarGi SagarGi force-pushed the fix/nightly_hard_failure_for_officesuites_tests branch 2 times, most recently from b790a58 to 3056d65 Compare September 8, 2023 07:00
@SwikritiT SwikritiT changed the title [test-only][full-ci]Discard new tab wait for file creation and public link open [tests-only][full-ci]Discard new tab wait for file creation and public link open Sep 8, 2023
@SagarGi SagarGi force-pushed the fix/nightly_hard_failure_for_officesuites_tests branch from 3056d65 to b74236d Compare September 8, 2023 08:36
@SagarGi SagarGi requested a review from saw-jan September 8, 2023 08:36
.drone.star Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the fix/nightly_hard_failure_for_officesuites_tests branch from b74236d to 453352a Compare September 8, 2023 09:56
@SagarGi SagarGi requested a review from saw-jan September 8, 2023 09:57
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi force-pushed the fix/nightly_hard_failure_for_officesuites_tests branch from 453352a to 4a2e024 Compare September 8, 2023 11:01
@SagarGi SagarGi force-pushed the fix/nightly_hard_failure_for_officesuites_tests branch from 4a2e024 to 82d2c70 Compare September 8, 2023 11:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit ea013c9 into master Sep 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/nightly_hard_failure_for_officesuites_tests branch September 8, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants