fix: respect the open-in-new-tab-config for external apps #9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
respect-open-in-new-tab-external-apps
branch
from
24a9076 to
45daa33
Compare
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
Sep 7, 2023
delete-merged-branch
bot
deleted the
respect-open-in-new-tab-external-apps
branch
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Respect the
WEB_OPTION_OPEN_APPS_IN_TABconfig for external apps.Although this is a bugfix I decided to target it to master because it is a change in user behaviour which we don't want to introduce with a new patch version.
Related Issue
Types of changes