Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] - use KQL as default search query language #9653

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Sep 5, 2023

Description

We've introduced KQL as our default query language.
Previously we used our own simple language for queries which is now replaced by kql.

sample.tx* Tags:important Tags:report Content:annual*

becomes

name:"sample.tx*" AND tag:important AND tag:report AND content:"annual*"

by default KQL uses AND as property restriction and the query described above can also be formulated as follows

name:"sample.tx*" tag:important tag:report content:"annual*"

More advanced syntax like grouping combined with boolean property restriction is supported too

(name:"sample*" name:"*txt") tag:important OR tag:report content:"annual*"

Related Issue

Motivation and Context

Defining a own query language is error prone and leads to a lot of documentation, the oCIS team decided in that ADR to use KQL as our standard. A clear set of rules is set by MS and the dictionary fits well in our usecase.

How Has This Been Tested?

  • unit tests have been adjusted
  • acceptance tests have been adjusted

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants