Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9493 expiration date three dot menu #9584

Merged
merged 9 commits into from
Aug 24, 2023
Merged

9493 expiration date three dot menu #9584

merged 9 commits into from
Aug 24, 2023

Conversation

grimmoc
Copy link
Contributor

@grimmoc grimmoc commented Aug 16, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@grimmoc grimmoc marked this pull request as ready for review August 16, 2023 10:36
@grimmoc grimmoc requested review from JammingBen and fschade August 16, 2023 10:36
JammingBen
JammingBen reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice, only a few nitpicks from my side.

I'm afraid we're going to have failing e2e- and acceptance-tests though 🙈 Let's see what the pipeline has to say once it's running.

changelog/unreleased/enhancement-set-expiration-date-in-three-dots-menu Outdated Show resolved Hide resolved
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue Outdated Show resolved Hide resolved
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue Outdated Show resolved Hide resolved
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue Outdated Show resolved Hide resolved
@JammingBen
Copy link
Contributor

JammingBen commented Aug 17, 2023 •
edited
Loading

One final nitpick: It would be nice to close the drop menu after selecting a date. See how it is done here: https://github.com/owncloud/web/blob/9493-expiration-date-three-dot-menu/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue#L424.

You just need to define a ref inside setup and return it. Then give the oc-drop element that ref via ref="..." to access and hide it in collaboratorExpiryChanged(). -> As discussed, let's keep it that way as it does make sense actually in this case.

@fschade
Copy link
Contributor

fschade commented Aug 24, 2023

@grimmoc please rebase, let me know if help is needed

@grimmoc grimmoc force-pushed the 9493-expiration-date-three-dot-menu branch from 7928459 to 418901b Compare August 24, 2023 12:02
lookacat
lookacat approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

52.8% 52.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear merged commit 36f579f into master Aug 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the 9493-expiration-date-three-dot-menu branch August 24, 2023 14:16
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@grimmoc @AlexAndBear
9493 expiration date three dot menu (#9584)
8be942b 
* unfinished

* finished styling etc

* added changelog

* removed debugging statements

* removed redundant variables

* quality control

* removed ide renaming quirk

* fixed acceptance tests + renamed drop

* fixed final comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen left review comments

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@lookacat lookacat lookacat approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grimmoc @JammingBen @fschade @lookacat @AlexAndBear