Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type-check): remove unnecessary passing of arg in useKeyboardActions #9570

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix(type-check): remove unnecessary passing of arg in useKeyboardActions #9570

merged 1 commit into from
Aug 11, 2023

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Aug 11, 2023 •
edited
Loading

Description

command pnpm check:style is failing with:

packages/web-app-admin-settings/src/components/Groups/GroupsList.vue(260,43): error TS2554: Expected 0 arguments, but got 1.
packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue(458,43): error TS2554: Expected 0 arguments, but got 1.
packages/web-app-admin-settings/src/components/Users/UsersList.vue(307,43): error TS2554: Expected 0 arguments, but got 1.
 ELIFECYCLE  Command failed with exit code 2.

I have removed the unnecessary passing of arg in function useKeyboardActions. The change was introduced in #9559

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Aug 11, 2023
@saw-jan saw-jan requested a review from dschmidt August 11, 2023 06:05
@saw-jan saw-jan changed the title fix: remove unnecessary passing of arg in useKeyboardActions fix(type-check): remove unnecessary passing of arg in useKeyboardActions Aug 11, 2023
@owncloud owncloud deleted a comment from update-docs bot Aug 11, 2023
@saw-jan saw-jan requested a review from AlexAndBear August 11, 2023 06:08
JammingBen
JammingBen approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit ab1d801 into master Aug 11, 2023
@saw-jan saw-jan deleted the fix-function-arg branch August 11, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@saw-jan saw-jan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot build web
3 participants
@saw-jan @AlexAndBear @JammingBen