Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loading pdf files with Safari #9565

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: loading pdf files with Safari #9565

merged 1 commit into from
Aug 11, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 10, 2023 •
edited
Loading

Description

Due to a Safari bug, we must not use application/pdf as object type when loading PDF files. See https://discussions.apple.com/thread/252247740 e.g.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen
fix: loading pdf files with Safari
6845e4d 
Due to a Safari bug, we must not use `application/pdf` as object type when loading PDF files.
@JammingBen JammingBen self-assigned this Aug 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JammingBen JammingBen merged commit c5a8024 into stable-7.1 Aug 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-pdf-loading-safari branch August 11, 2023 07:56
@JammingBen JammingBen mentioned this pull request Aug 11, 2023
Closed
ownclouders pushed a commit that referenced this pull request Aug 11, 2023
@JammingBen
Merge pull request #9565 from owncloud/fix-pdf-loading-safari
889b4de 
fix: loading pdf files with Safari
ownclouders pushed a commit that referenced this pull request Aug 12, 2023
@JammingBen
Merge pull request #9565 from owncloud/fix-pdf-loading-safari
b077a5b 
fix: loading pdf files with Safari
ownclouders pushed a commit that referenced this pull request Aug 13, 2023
@JammingBen
Merge pull request #9565 from owncloud/fix-pdf-loading-safari
414b856 
fix: loading pdf files with Safari
ownclouders pushed a commit that referenced this pull request Aug 14, 2023
@JammingBen
Merge pull request #9565 from owncloud/fix-pdf-loading-safari
4707622 
fix: loading pdf files with Safari
ownclouders pushed a commit that referenced this pull request Aug 15, 2023
@JammingBen
Merge pull request #9565 from owncloud/fix-pdf-loading-safari
b04dea6 
fix: loading pdf files with Safari
@JammingBen JammingBen mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@grimmoc grimmoc grimmoc approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @dschmidt @grimmoc