-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: upload preparation time #9552
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Status: This needs some more testing, I don't want to get it into |
9b73dea
to
897dce4
Compare
Massively improves the upload preparation time. Instead of setting file data on each file, we now accumulate all the data first and then set it in one batch via Uppy's `setState` method.
897dce4
to
fa9ccdb
Compare
SonarCloud Quality Gate failed. 2 Bugs 74.4% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Ah this would be a huge improvement regarding the upload experience 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM wondering how much faster we'll be
The improvement is quite huge actually, especially with a lot of files 🥳
|
Whoop whoop 🙌 |
perf: upload preparation time
perf: upload preparation time
perf: upload preparation time
dude, this is huge!!! ❤️ |
Description
Massively improves the upload preparation time. Instead of setting file data on each file, we now accumulate all the data first and then set it in one batch via Uppy's
setState
method.Related Issue
Types of changes