Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: upload preparation time #9552

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 8, 2023

Description

Massively improves the upload preparation time. Instead of setting file data on each file, we now accumulate all the data first and then set it in one batch via Uppy's setState method.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 8, 2023
@update-docs
Copy link

update-docs bot commented Aug 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen
Copy link
Contributor Author

Status: This needs some more testing, I don't want to get it into 7.1.0. Hence wait until we finally released it.

@JammingBen JammingBen force-pushed the upload-preparation-time branch from 9b73dea to 897dce4 Compare August 17, 2023 13:38
Massively improves the upload preparation time. Instead of setting file data on each file, we now accumulate all the data first and then set it in one batch via Uppy's `setState` method.
@JammingBen JammingBen force-pushed the upload-preparation-time branch from 897dce4 to fa9ccdb Compare September 5, 2023 07:12
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.4% 74.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen marked this pull request as ready for review September 5, 2023 07:36
@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 6, 2023

Ah this would be a huge improvement regarding the upload experience 🙏

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wondering how much faster we'll be

@JammingBen
Copy link
Contributor Author

LGTM wondering how much faster we'll be

The improvement is quite huge actually, especially with a lot of files 🥳

  • 2000 files: from 1 second down to 30 milliseconds
  • 6000 files: from 12 seconds down to 100 milliseconds (!)

@AlexAndBear
Copy link
Contributor

Whoop whoop 🙌

@JammingBen JammingBen merged commit f4e8ddb into stable-7.1 Sep 6, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the upload-preparation-time branch September 6, 2023 10:58
ownclouders pushed a commit that referenced this pull request Sep 6, 2023
ownclouders pushed a commit that referenced this pull request Sep 7, 2023
ownclouders pushed a commit that referenced this pull request Sep 8, 2023
@kulmann
Copy link
Member

kulmann commented Nov 8, 2023

LGTM wondering how much faster we'll be

The improvement is quite huge actually, especially with a lot of files 🥳

  • 2000 files: from 1 second down to 30 milliseconds
  • 6000 files: from 12 seconds down to 100 milliseconds (!)

dude, this is huge!!! ❤️

JammingBen added a commit that referenced this pull request Nov 23, 2023
JammingBen added a commit that referenced this pull request Nov 24, 2023
JammingBen added a commit that referenced this pull request Nov 24, 2023
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants