Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiles view - keyboard navigation, dynamic allocation based on view mode #9542

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Tiles view - keyboard navigation, dynamic allocation based on view mode #9542

merged 5 commits into from
Aug 15, 2023

Conversation

jacob-nv
Copy link
Contributor

@jacob-nv jacob-nv commented Aug 3, 2023 •
edited
Loading

Description

Adding ability to switch between different views, automatically binding and unbinding keybinds

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 3, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jacob-nv jacob-nv marked this pull request as ready for review August 4, 2023 09:05
JammingBen
JammingBen reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shift + arrow navigation behaves a bit weird. Let's say I have 6 resources in a 3x2 grid (tiles-size=3). Then I select the first resource. Then I go down -> right -> up. It will de-select the previously selected resource.

@jacob-nv
Copy link
Contributor Author

jacob-nv commented Aug 9, 2023

The shift + arrow navigation behaves a bit weird. Let's say I have 6 resources in a 3x2 grid (tiles-size=3). Then I select the first resource. Then I go down -> right -> up. It will de-select the previously selected resource.

Okay, what if I do it same as in files in desktop?
In 3x2 grid.
Select first resource, then go down, it will select whole first row and first tile of second row?

@jacob-nv jacob-nv requested a review from JammingBen August 9, 2023 16:22
@JammingBen
Copy link
Contributor

Select first resource, then go down, it will select whole first row and first tile of second row?

That would be fine IMO!

@jacob-nv
Copy link
Contributor Author

Select first resource, then go down, it will select whole first row and first tile of second row?

That would be fine IMO!

Pushed update, please test it if it's to you liking. If so, I'll try to rewrite code into something more streamlined

@JammingBen
Copy link
Contributor

Pushed update, please test it if it's to you liking. If so, I'll try to rewrite code into something more streamlined

Works fine for me 👍

@jacob-nv
Merge branch 'master' into tiles-view-keyboard
1f1bf25 
# Conflicts:
#	packages/web-app-files/src/components/Search/List.vue
#	packages/web-app-files/src/views/spaces/GenericSpace.vue
@jacob-nv
Tiles navigation simplifying code
d90ab64
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 12 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

23.9% 23.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen merged commit 50c8945 into owncloud:master Aug 15, 2023
ownclouders pushed a commit that referenced this pull request Aug 15, 2023
@jacob-nv
Tiles view - keyboard navigation, dynamic allocation based on view mo…
7cc1811 
…de (#9542)

* Tiles view - keyboard navigation, dynamic allocation based on view mode

* Tiles keyboard navigation, selection

* Tiles navigation, shift selection

* Tiles navigation simplifying code
ownclouders pushed a commit that referenced this pull request Aug 16, 2023
@jacob-nv
Tiles view - keyboard navigation, dynamic allocation based on view mo…
ff2bfd3 
…de (#9542)

* Tiles view - keyboard navigation, dynamic allocation based on view mode

* Tiles keyboard navigation, selection

* Tiles navigation, shift selection

* Tiles navigation simplifying code
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@jacob-nv @AlexAndBear
Tiles view - keyboard navigation, dynamic allocation based on view mo…
9c55011 
…de (#9542)

* Tiles view - keyboard navigation, dynamic allocation based on view mode

* Tiles keyboard navigation, selection

* Tiles navigation, shift selection

* Tiles navigation simplifying code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tiles view] keyboard interaction
2 participants
@jacob-nv @JammingBen