Search Bar filter translation #9528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
9 tasks
JammingBen
suggested changes
Aug 2, 2023
| @@ -64,12 +64,12 @@ export default defineComponent({ | |||
| const locationOptions = ref<LocationOption[]>([ | |||
| { | |||
| id: SearchLocationFilterConstants.currentFolder, | |||
| title: $gettext('Current Folder'), | |||
| title: 'Current Folder', | |||
There was a problem hiding this comment.
Please don't remove $gettext here. This method (and its variations) are an indicator for our language string extractor to sync strings to Transifex, where they eventually get translated.
There was a problem hiding this comment.
Right, looks like my previous approach was better. And it seems that moving "currentFolderEnabled" prop from computed into locationOptions (as computed) fixed the issue
| @@ -122,7 +122,7 @@ export default defineComponent({ | |||
| emit('update:modelValue', { value: option }) | |||
| } | |||
|
|
|||
| return { currentSelection, isIndexGreaterZero, onOptionSelected, locationOptions } | |||
| return { currentSelection, isIndexGreaterZero, onOptionSelected, locationOptions, $gettext } | |||
There was a problem hiding this comment.
No need to return it explicitly.
Suggested change
| return { currentSelection, isIndexGreaterZero, onOptionSelected, locationOptions, $gettext } | |
| return { currentSelection, isIndexGreaterZero, onOptionSelected, locationOptions} |
|
Kudos, SonarCloud Quality Gate passed!
|
JammingBen
approved these changes
Aug 4, 2023
AlexAndBear
approved these changes
Aug 4, 2023
ownclouders
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Search Bar filter translation * SearchBar filter fixing translation
ownclouders
pushed a commit
that referenced
this pull request
Aug 5, 2023
* Search Bar filter translation * SearchBar filter fixing translation
ownclouders
pushed a commit
that referenced
this pull request
Aug 6, 2023
* Search Bar filter translation * SearchBar filter fixing translation
ownclouders
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Search Bar filter translation * SearchBar filter fixing translation
ownclouders
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Search Bar filter translation * SearchBar filter fixing translation
JammingBen
added a commit
that referenced
this pull request
Aug 17, 2023
This reverts commit dd2c63c.
JammingBen
added a commit
that referenced
this pull request
Aug 17, 2023
* Revert "ct perm link (#9567)" This reverts commit 8b8c699. * Revert "Fix: show unrestricted as total quota if applies (#9577)" This reverts commit 98887c7. * Revert "Close on click stable fix" This reverts commit 8cd4e7b. * Revert "fix: loading pdf files with Safari" This reverts commit 6845e4d. * Revert "Search Bar filter translation (#9528)" This reverts commit dd2c63c. * Revert "Fix set or remove expiration date on groups not possible (#9513)" This reverts commit eb25832.
ownclouders
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Revert "ct perm link (#9567)" This reverts commit 8b8c699. * Revert "Fix: show unrestricted as total quota if applies (#9577)" This reverts commit 98887c7. * Revert "Close on click stable fix" This reverts commit 8cd4e7b. * Revert "fix: loading pdf files with Safari" This reverts commit 6845e4d. * Revert "Search Bar filter translation (#9528)" This reverts commit dd2c63c. * Revert "Fix set or remove expiration date on groups not possible (#9513)" This reverts commit eb25832.
ownclouders
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Revert "ct perm link (#9567)" This reverts commit 8b8c699. * Revert "Fix: show unrestricted as total quota if applies (#9577)" This reverts commit 98887c7. * Revert "Close on click stable fix" This reverts commit 8cd4e7b. * Revert "fix: loading pdf files with Safari" This reverts commit 6845e4d. * Revert "Search Bar filter translation (#9528)" This reverts commit dd2c63c. * Revert "Fix set or remove expiration date on groups not possible (#9513)" This reverts commit eb25832.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving translation to template keeps language and doesn't break "current folder"
Related Issue
Types of changes
Checklist: