[full-ci] Purge confirmation modal for deletion from files list #9527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
changed the title
dschmidt
reviewed
Aug 2, 2023
packages/web-app-files/src/composables/actions/files/useFileActionsDelete.ts
Outdated
Show resolved
Hide resolved
…tionsDelete.ts Co-authored-by: Dominik Schmidt <[email protected]>
AlexAndBear
force-pushed
the
issues/5974
branch
3 times, most recently
from
6214c02 to
193662a
Compare
AlexAndBear
force-pushed
the
issues/5974
branch
from
16e7c5e to
bd0ba11
Compare
JammingBen
reviewed
Aug 3, 2023
|
SonarCloud Quality Gate failed.
|
JammingBen
approved these changes
Aug 3, 2023
AlexAndBear
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Purge confirmation modal for deletion from files list * Don't toggle toggleModalConfirmButton n times * Remove modal store actions, as modal won't be displayed anymore * Lint * Fix unit tests * Fix e2e tests * fix acceptance tests+ * Add notifications * Update packages/web-app-files/src/composables/actions/files/useFileActionsDelete.ts Co-authored-by: Dominik Schmidt <[email protected]> * Add missing import * add changelog item# * Fix acceptance tests * don't use gettext twice --------- Co-authored-by: Dominik Schmidt <[email protected]>
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Purge confirmation modal for deletion from files list * Don't toggle toggleModalConfirmButton n times * Remove modal store actions, as modal won't be displayed anymore * Lint * Fix unit tests * Fix e2e tests * fix acceptance tests+ * Add notifications * Update packages/web-app-files/src/composables/actions/files/useFileActionsDelete.ts Co-authored-by: Dominik Schmidt <[email protected]> * Add missing import * add changelog item# * Fix acceptance tests * don't use gettext twice --------- Co-authored-by: Dominik Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: