Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport x-request-id to 7.1 stable #9523

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

Jan and others added 7 commits August 2, 2023 10:22
* Add dismiss button to oc-notification-message

* Add changelog item
* add error description to oc-notification-message

* Enhancemnets

* Add new component

* Fix description

* Fix position

* Add changelog item

* Fix typo

* Fix

* Align title icon center on y axis

* Prettify

* Add missing export

* Add remove test code

* add unit test

* Fix tests

* Enhance label

* Fix tests

* Fix tests
* Add error log to upload service

* Add changelog item

* Rm not needed surrounding div

* add computed

* Fix styling

* Fix spacing
* Add showErrorMessage store action

* fix

* fix unit tests

* lint

* Fix unit tests

* Apply to ConflictDialog

* fix unit tests

* Fix interface not fullfilled

* Fix

* Fix error message don't disappear automatially

* Reintroduce title testing

* Clear error messages

* Fix clearErrorMessage selector

* Fix synthax

* Kick wait for closing error automatically

* adjust line numbers
* Show error log in graph requests

* Add more

* Fix

* Reformat

* Fix

* Access response headers

* Fix bug

* Fix bug
@AlexAndBear AlexAndBear marked this pull request as ready for review August 2, 2023 09:32
@AlexAndBear AlexAndBear changed the title Backport x request Backport x-request-id to 7.1 stable Aug 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

49.7% 49.7% Coverage
16.2% 16.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen merged commit 657b913 into stable-7.1 Aug 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport-x-request-id branch August 2, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants