Limit relative quota in user menu to two decimals #9369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
dschmidt
approved these changes
Jul 8, 2023
kulmann
reviewed
Jul 8, 2023
| @@ -210,7 +210,7 @@ export default defineComponent({ | |||
| }, | |||
| quotaUsagePercent() { | |||
| return this.useLegacyQuota | |||
| ? this.quota.relative | |||
| ? parseFloat(this.quota.relative.toFixed(2)) | |||
There was a problem hiding this comment.
Only parse this.quota.relative to float and then to a toFixed(2) on the result.
There was a problem hiding this comment.
I did that initially but then quotaUsagePercent is string | number and it gets messy further down where we're calculating how much free quota is left to change the color of the OcProgress component.
The alternative was parseFloat(parseFloat(this.quota.relative).toFixed(2)) but that also didn't really feel right...
There was a problem hiding this comment.
We'll go ahead as-is and can adapt (= add another parseFloat) if EOS/Reva requires it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue