Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Long links in notifications are cut off #9144

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Bugfix: Long links in notifications are cut off #9144

merged 2 commits into from
Jun 2, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jun 1, 2023

Description

See #9053

Related Issue

Screenshots (if appropriate):

Screenshot (38)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 1, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review June 1, 2023 12:58
@lookacat lookacat requested review from JammingBen and kulmann June 1, 2023 12:59
@lookacat lookacat changed the base branch from master to stable-7.0 June 1, 2023 14:22
@lookacat lookacat changed the base branch from stable-7.0 to master June 1, 2023 14:23
JammingBen
JammingBen approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please target to stable-7.0 though 🙂

@kulmann kulmann force-pushed the notifications-link-bugfix-9053 branch from 917f5af to cb05b68 Compare June 2, 2023 11:29
@kulmann kulmann changed the base branch from master to stable-7.0 June 2, 2023 11:29
@ownclouders
Copy link
Contributor

ownclouders commented Jun 2, 2023 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/36259/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36259/tracing/deny-and-grant-access-alice-2023-6-2-12-15-01.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@kulmann kulmann force-pushed the notifications-link-bugfix-9053 branch from cb05b68 to 433dc44 Compare June 2, 2023 12:44
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 6ac3c7c into stable-7.0 Jun 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the notifications-link-bugfix-9053 branch June 2, 2023 13:15
@JammingBen JammingBen mentioned this pull request Jun 7, 2023
Closed
86 tasks
@JammingBen JammingBen mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long links in notifications are cut off
4 participants
@lookacat @ownclouders @kulmann @JammingBen