Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: share indicator loading after pasting resources #9110

Merged
merged 1 commit into from
May 26, 2023
Merged

fix: share indicator loading after pasting resources #9110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-share-indicator-after-pasting
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Share indicator loading after pasting resources

Share indicators are now being displayed correctly after pasting resources into shared folders.

https://github.com/owncloud/web/issues/9030
https://github.com/owncloud/web/pull/9110
2 changes: 2 additions & 0 deletions packages/web-app-files/src/store/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ export default {
}

return Promise.all(loadingResources).then(() => {
const currentFolder = context.getters.currentFolder
context.commit('UPSERT_RESOURCES', fetchedResources)
context.commit('LOAD_INDICATORS', currentFolder.path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible that the currentFolder var can be nullish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I don't see a scenario where we don't have a folder to paste into. Do you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. And now that I looked at it in detail - the currentFolder is already used at the top of the function. So yeah, fine like that 😅

})
},
{ debounceTime: 0 }
Expand Down