Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle upload errors #9076

Merged
merged 3 commits into from
May 23, 2023
Merged

Handle upload errors #9076

merged 3 commits into from
May 23, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 22, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear changed the base branch from master to stable-7.0 May 22, 2023 13:30
@AlexAndBear AlexAndBear requested review from kulmann and fschade May 22, 2023 13:41
fschade
fschade approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AlexAndBear AlexAndBear requested a review from dschmidt May 22, 2023 13:45
@AlexAndBear AlexAndBear marked this pull request as ready for review May 22, 2023 13:45
@AlexAndBear AlexAndBear requested a review from lookacat May 23, 2023 08:02
lookacat
lookacat approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

kulmann
kulmann previously requested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog item please 😁

@AlexAndBear AlexAndBear requested a review from kulmann May 23, 2023 12:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann dismissed their stale review May 23, 2023 13:35

unblock

@AlexAndBear AlexAndBear merged commit 8fa5807 into stable-7.0 May 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the handle-upload-errors branch May 23, 2023 13:37
@JammingBen JammingBen mentioned this pull request Jun 7, 2023
Closed
86 tasks
@dschmidt dschmidt mentioned this pull request Jun 29, 2023
Closed
37 tasks
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@fschade fschade fschade approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
Early-Adopter:CERN Platform:Web
Projects
None yet
Milestone
CERN Web Merge
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexAndBear @lookacat @kulmann @fschade @tbsbdr