[full-ci] Public-link open default action on single file share #9046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/36173/13/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIPrivateLinks-accessingPrivateLinks_feature-L18.png |
|
Todo:
|
lookacat
reviewed
May 16, 2023
lookacat
suggested changes
May 16, 2023
AlexAndBear
commented
May 16, 2023
packages/web-app-files/src/components/FilesList/ResourceDetails.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
commented
May 16, 2023
packages/web-app-files/src/components/FilesList/ResourceDetails.vue
Outdated
Show resolved
Hide resolved
JammingBen
reviewed
May 16, 2023
packages/web-app-files/tests/unit/components/FilesList/ResourceDetails.spec.ts
Outdated
Show resolved
Hide resolved
AlexAndBear
commented
May 16, 2023
packages/web-app-files/tests/unit/components/FilesList/ResourceDetails.spec.ts
Outdated
Show resolved
Hide resolved
|
Needs https://github.com/owncloud/ocis/pull/6328/files for configuration |
kulmann
requested changes
May 17, 2023
packages/web-app-files/src/components/FilesList/ResourceDetails.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/FilesList/ResourceDetails.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
commented
May 17, 2023
|
@kulmann this has been fixed |
kulmann
force-pushed
the
public-share-exec-default-action
branch
from
727fda9 to
aaaa8bf
Compare
kulmann
changed the title
kulmann
force-pushed
the
public-share-exec-default-action
branch
from
300973c to
f2318c6
Compare
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/36154/65/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkPublicActions_feature-L12.png |
AlexAndBear
force-pushed
the
public-share-exec-default-action
branch
from
f2318c6 to
ab1102f
Compare
AlexAndBear
force-pushed
the
public-share-exec-default-action
branch
from
672a7c3 to
ed3a071
Compare
AlexAndBear
force-pushed
the
public-share-exec-default-action
branch
2 times, most recently
from
60043c4 to
4bc0f03
Compare
lookacat
approved these changes
May 30, 2023
AlexAndBear
force-pushed
the
public-share-exec-default-action
branch
from
b3e2295 to
e6556ec
Compare
ownclouders
pushed a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: