Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Implement tag filter on search result page #9044

Merged
merged 4 commits into from
May 17, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented May 15, 2023

Description

Adds a tag filter to the search result page which can be used to filter the displayed search result by tags.

This was a bit more complicated than I anticipated, mainly because of 2 issues I encountered:

  • The file list component's purpose was to simply display a search result, meaning the component could not trigger a search. Triggering a search was done by the parent component in the search app instead. With the filter now living inside the files component, I decided to changed this. The component in the files app now emits a search event to the parent component which eventually handles the search. This way, all the filter logic stays decoupled in the files list component.
  • The filter chip's visual state can be changed by either interacting with the filter directly or by loading the page initially with given filter query params. On the search result page however, there is a third way to filter resources: by clicking a tag in the files list. The filter chip won't notice this change unless you tell the component to do so - which is why I exposed the method setSelectedItemsBasedOnQuery to its parent.

Related Issue

Screenshot

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 15, 2023
@JammingBen JammingBen force-pushed the search-tag-filter branch 7 times, most recently from 3e2916a to 5eb641a Compare May 16, 2023 11:35
@ownclouders
Copy link
Contributor

ownclouders commented May 16, 2023

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35721/52/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAcceptShares-acceptShares_feature-L174.png

webUISharingAcceptShares-acceptShares_feature-L174.png

webUISharingAcceptShares-acceptShares_feature-L223.png

webUISharingAcceptShares-acceptShares_feature-L223.png

💥 The oCISSharingBasic tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the search-tag-filter branch from 5eb641a to e140ca8 Compare May 16, 2023 11:49
@owncloud owncloud deleted a comment from update-docs bot May 16, 2023
@JammingBen JammingBen force-pushed the search-tag-filter branch from e140ca8 to dbde53b Compare May 16, 2023 11:58
@ownclouders
Copy link
Contributor

ownclouders commented May 16, 2023

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35727/19/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L109.png

webUIFilesSearch-search_feature-L109.png

webUIFilesSearch-search_feature-L121.png

webUIFilesSearch-search_feature-L121.png

webUIFilesSearch-search_feature-L131.png

webUIFilesSearch-search_feature-L131.png

webUIFilesSearch-search_feature-L33.png

webUIFilesSearch-search_feature-L33.png

webUIFilesSearch-search_feature-L41.png

webUIFilesSearch-search_feature-L41.png

webUIFilesSearch-search_feature-L85.png

webUIFilesSearch-search_feature-L85.png

@JammingBen JammingBen changed the title Implement tag filter on search result page [full-ci] Implement tag filter on search result page May 16, 2023
@JammingBen JammingBen force-pushed the search-tag-filter branch from dbde53b to df6cff1 Compare May 16, 2023 12:36
@JammingBen JammingBen force-pushed the search-tag-filter branch from df6cff1 to 9d528f0 Compare May 16, 2023 13:16
@JammingBen JammingBen force-pushed the search-tag-filter branch from a138ca2 to 3108b1f Compare May 17, 2023 07:49
@JammingBen JammingBen marked this pull request as ready for review May 17, 2023 08:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

76.7% 76.7% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit f7347e2 into master May 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-tag-filter branch May 17, 2023 14:57
pascalwengerter pushed a commit to pascalwengerter/web that referenced this pull request May 22, 2023
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Add "Tags" filter Chip
4 participants