-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Implement tag filter on search result page #9044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
search-tag-filter
branch
7 times, most recently
from
May 16, 2023 11:35
3e2916a
to
5eb641a
Compare
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35721/52/1 💥 The oCISSharingBasic tests pipeline failed. The build has been cancelled. |
JammingBen
force-pushed
the
search-tag-filter
branch
from
May 16, 2023 11:49
5eb641a
to
e140ca8
Compare
JammingBen
force-pushed
the
search-tag-filter
branch
from
May 16, 2023 11:58
e140ca8
to
dbde53b
Compare
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35727/19/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesSearch-search_feature-L109.pngwebUIFilesSearch-search_feature-L121.pngwebUIFilesSearch-search_feature-L131.pngwebUIFilesSearch-search_feature-L33.pngwebUIFilesSearch-search_feature-L41.pngwebUIFilesSearch-search_feature-L85.png |
JammingBen
changed the title
Implement tag filter on search result page
[full-ci] Implement tag filter on search result page
May 16, 2023
JammingBen
force-pushed
the
search-tag-filter
branch
from
May 16, 2023 12:36
dbde53b
to
df6cff1
Compare
JammingBen
force-pushed
the
search-tag-filter
branch
from
May 16, 2023 13:16
df6cff1
to
9d528f0
Compare
JammingBen
force-pushed
the
search-tag-filter
branch
from
May 17, 2023 07:49
a138ca2
to
3108b1f
Compare
lookacat
reviewed
May 17, 2023
lookacat
reviewed
May 17, 2023
JammingBen
force-pushed
the
search-tag-filter
branch
from
May 17, 2023 09:11
49a4688
to
3108b1f
Compare
5 tasks
AlexAndBear
approved these changes
May 17, 2023
Kudos, SonarCloud Quality Gate passed! |
pascalwengerter
pushed a commit
to pascalwengerter/web
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a tag filter to the search result page which can be used to filter the displayed search result by tags.
This was a bit more complicated than I anticipated, mainly because of 2 issues I encountered:
search
event to the parent component which eventually handles the search. This way, all the filter logic stays decoupled in the files list component.setSelectedItemsBasedOnQuery
to its parent.Related Issue
Screenshot
Types of changes