[tests-only]Add tests for pagination in personal space #9008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
tests/e2e-test-pagination-files
branch
from
880d480 to
39466cd
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/35625/11/1 |
SwikritiT
force-pushed
the
tests/e2e-test-pagination-files
branch
from
adcc63a to
80b0b9b
Compare
SwikritiT
changed the title
SwikritiT
commented
May 12, 2023
Comment on lines
-31
to
-32
| # Remove when https://github.com/owncloud/core/pull/40024 is merged and released | ||
| php occ config:system:set cors.allowed-headers --type json --value '["cache-control"]' |
There was a problem hiding this comment.
The mentioned PR has been merged so can be removed
SwikritiT
commented
May 12, 2023
| @@ -22,12 +22,11 @@ else | |||
| then | |||
| php occ config:system:set web.baseUrl --value="http://owncloud/index.php/apps/web" | |||
| php occ config:system:set enable_previews --type=boolean --value=false | |||
| php occ config:system:set skeletondirectory --value='' | |||
There was a problem hiding this comment.
Don't set the skeleton folder in the core so that the same test can be run for both core and ocis
SwikritiT
force-pushed
the
tests/e2e-test-pagination-files
branch
from
c7d02d8 to
ddfdfd2
Compare
SwikritiT
requested review from
SagarGi,
saw-jan,
ScharfViktor,
grgprarup,
amrita-shrestha and
PrajwolAmatya
SagarGi
reviewed
May 15, 2023
SwikritiT
force-pushed
the
tests/e2e-test-pagination-files
branch
from
9289a25 to
2c6984d
Compare
saw-jan
reviewed
May 15, 2023
saw-jan
reviewed
May 15, 2023
saw-jan
reviewed
May 15, 2023
tests/e2e/cucumber/features/smoke/personalSpacePagination.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
May 15, 2023
tests/e2e/cucumber/features/smoke/personalSpacePagination.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
May 15, 2023
tests/e2e/cucumber/features/smoke/personalSpacePagination.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
May 15, 2023
saw-jan
reviewed
May 15, 2023
saw-jan
reviewed
May 15, 2023
saw-jan
reviewed
May 15, 2023
saw-jan
reviewed
May 15, 2023
SwikritiT
force-pushed
the
tests/e2e-test-pagination-files
branch
from
7e2a9fd to
2a91c47
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ScharfViktor
approved these changes
May 15, 2023
lookacat
pushed a commit
that referenced
this pull request
May 17, 2023
* Add tests for pagination presonal space * set skeleton to emply for tests * remove the reduntant config * add logout step * address reviews * address reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test to check the pagination in personal space page
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: