Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Cleanup group created by test scenario at after hook #8994

Merged
merged 1 commit into from
May 11, 2023
Merged

[tests-only][full-ci] Cleanup group created by test scenario at after hook #8994

merged 1 commit into from
May 11, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This issue clean-up the group in the After hook.

Related Issue

Part of

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha self-assigned this May 8, 2023
@amrita-shrestha amrita-shrestha mentioned this pull request May 8, 2023
Closed
3 tasks
@amrita-shrestha amrita-shrestha marked this pull request as ready for review May 9, 2023 03:56
SagarGi
SagarGi reviewed May 9, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

saw-jan
saw-jan reviewed May 9, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan requested a review from ScharfViktor May 9, 2023 08:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha requested a review from saw-jan May 9, 2023 10:04
@ScharfViktor
Copy link
Contributor

please port it to stable-7.0

@saw-jan saw-jan merged commit e2bfe8b into master May 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the cleanup-group branch May 11, 2023 03:47
saw-jan pushed a commit that referenced this pull request May 11, 2023
@amrita-shrestha @saw-jan
Clean created groups after scenario run (#8994)
59960bc
@saw-jan saw-jan mentioned this pull request May 11, 2023
Merged
9 tasks
saw-jan pushed a commit that referenced this pull request May 11, 2023
@amrita-shrestha @saw-jan
Clean created groups after scenario run (#8994)
77bf031
lookacat pushed a commit that referenced this pull request May 17, 2023
@amrita-shrestha @lookacat
Clean created groups after scenario run (#8994)
d2dfb3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @ScharfViktor @SagarGi @saw-jan