Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Implement long breadcrumb strategy #8984

Merged
merged 52 commits into from
May 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
ea2772e
Implement long breadcrumb strategy
lookacat May 4, 2023
2271aad
WIP
lookacat May 5, 2023
1577516
Bugfix use items in template, not visibleitems
lookacat May 8, 2023
446415a
WIP
lookacat May 8, 2023
c779d88
WIP
lookacat May 8, 2023
9ce8aa7
WIP
lookacat May 8, 2023
66cbe81
Fix ..., Fix first folder not showing up
lookacat May 9, 2023
519019a
Rename itemsWithDropdown
lookacat May 9, 2023
0aa705e
extract max breadcrumb width logic from OcBreadcrumb
lookacat May 9, 2023
995200e
Refactor code
lookacat May 9, 2023
16c30e9
Fix unreadable classes
lookacat May 9, 2023
941d91d
Fix long names
lookacat May 9, 2023
1bef832
Fix small screen size bug
lookacat May 9, 2023
8241c3f
dont use text as identifier in if statements ...
lookacat May 9, 2023
6aaa94a
remove console logs
lookacat May 9, 2023
6e65969
use const instead of let
lookacat May 9, 2023
274176b
remove dev styling
lookacat May 9, 2023
89d03a6
Update snapshots
lookacat May 9, 2023
8f92da3
Fix undefined error in unittests
lookacat May 9, 2023
cbce627
Fix undefined unittest error
lookacat May 9, 2023
27a1d67
Fix `...` item
lookacat May 10, 2023
33376a3
Add resize observer throttling to improve performance on resize
lookacat May 10, 2023
5d78a13
Fix ...
lookacat May 10, 2023
30f3049
Prevent breadcrumb from not displaying the current folder
lookacat May 10, 2023
cf0b0f8
reduce throttle
lookacat May 10, 2023
2afcfbb
Add prop description
lookacat May 10, 2023
1223f89
Fix bug build:w not working
lookacat May 10, 2023
bf85e0a
remove hacky css
lookacat May 10, 2023
a4c9a96
Update tests, refactor logic
lookacat May 10, 2023
01a7fd2
Fix PR issues
lookacat May 15, 2023
88f377a
Extract parent selector, remove dev leftover
lookacat May 15, 2023
4f96701
Rename allItemsIncludingThreeDots
lookacat May 15, 2023
43bbb52
Use oc-hidden instead of hide
lookacat May 15, 2023
3067939
Update prop descriptions
lookacat May 15, 2023
146392e
add window resize event listener again, because without it it causes …
lookacat May 15, 2023
530b04a
Add changelog
lookacat May 15, 2023
a00bdb9
Remove double arrow default value
lookacat May 15, 2023
ff72801
Small code slimming fix
lookacat May 16, 2023
5114193
Refactor maxWidth
lookacat May 17, 2023
4d36386
Update snapshot
lookacat May 17, 2023
6eae49f
Fix breadcrumb cut to early
lookacat May 17, 2023
3d0659c
Fix breadcrumbMaxSize calc, Address PR issues
lookacat May 19, 2023
7a6c78c
Fix console error
lookacat May 19, 2023
f061d88
Fix unittests
lookacat May 19, 2023
74acc72
Fix span positioning
lookacat May 19, 2023
80a5a65
Address current PR issues
lookacat May 23, 2023
3d2c44a
Update snapshot
lookacat May 23, 2023
8737838
Address PR issues
lookacat May 23, 2023
c7bd0b1
Address PR issues
lookacat May 24, 2023
4726512
Address PR issue
lookacat May 24, 2023
b1dd5c7
React on code review
May 24, 2023
70bc349
fix: breadcrumb truncation in project spaces, linting, unit tests
kulmann May 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/web-app-files/src/components/AppBar/AppBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ import {
useFileActionsMove,
useFileActionsRestore
} from 'web-app-files/src/composables/actions'
import { useRoute, useRouter, useStore } from 'web-pkg/src'
import { useRouter, useStore } from 'web-pkg/src'
import { BreadcrumbItem } from 'design-system/src/components/OcBreadcrumb/types'
import { useActiveLocation } from 'web-app-files/src/composables'

Expand Down Expand Up @@ -136,7 +136,6 @@ export default defineComponent({
setup(props) {
const store = useStore()
const router = useRouter()
const route = useRoute()

const { actions: acceptShareActions } = useFileActionsAcceptShare({ store })
const { actions: clearSelectionActions } = useFileActionsClearSelection({ store })
Expand Down Expand Up @@ -193,11 +192,15 @@ export default defineComponent({
})

const breadcrumbTruncationOffset = computed(() => {
return isLocationSpacesActive(router, 'files-spaces-projects') ? 3 : 2
if (!props.space) {
return 2
}
return isLocationSpacesActive(router, 'files-spaces-projects') &&
!isPersonalSpaceResource(unref(props.space))
? 3
: 2
})

console.log('offset', route)

return {
batchActions,
showBreadcrumb,
Expand Down