[full-ci] feature-deny-access

[AlexAndBear]

Description

Enhancement: deny share access

We've added a way to deny the share access in sub folders in a share or space.
This allows the share editors to restrict access to certain resources within a share for certain share receivers.

Related Issue

• Fix [web] Deny access #7180

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[JammingBen]

I'm totally not into the feature scope here, but is it intended that you can deny access only on folders, but not files?

Also, the PR increased some of the context actions height:

[ownclouders]

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35474/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers_feature-L156.png

[AlexAndBear]

TBD:

• Add e2e tests
• Implement logic for spaces

[AlexAndBear]

I'm totally not into the feature scope here, but is it intended that you can deny access only on folders, but not files?

Also, the PR increased some of the context actions height:

Fixed =)

but is it intended that you can deny access only on folders, but not files?

Unfortantly only works on folders, due to backend limitations

[AlexAndBear]

This PR killed my last brain cell, please review carefully

[kulmann]

Puh. Big and tough one... I love it so far!

Things that need to be solved as well, but can be a followup:

• subfolder/files inside an already denied folder should be shown as Access denied as well (we already discussed this, just for completeness)
• the Shared with others page should not include the denials in the listing. They can just completely disappear from that page (remember that we want to hide the technical detail of a denial being a share from the user)
• Space member listing shows the logged in user in the list. But the Deny access option should not be listed in the context menu for the logged in user.

[AlexAndBear]

subfolder/files inside an already denied folder should be shown as Access denied as well (we already discussed this, just for completeness)

Implemented

the Shared with others page should not include the denials in the listing. They can just completely disappear from that page (remember that we want to hide the technical detail of a denial being a share from the user)

Fixed

Space member listing shows the logged in user in the list. But the Deny access option should not be listed in the context menu for the logged in user.

Fixed

[ScharfViktor]

LGTM on the testing side

[kulmann]

Awesome 💪

[sonarqubecloud]

SonarCloud Quality Gate failed.   

8 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

52.7% Coverage
0.0% Duplication