Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share loading when adding a link via quick action #8915

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix share loading when adding a link via quick action #8915

merged 2 commits into from
Apr 27, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Apr 26, 2023 •
edited
Loading

Description

When adding/removing shares while the shares are currently in a loading state, we need to wait for the loading to be finished.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Apr 26, 2023
@ownclouders
Copy link
Contributor

ownclouders commented Apr 26, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35163/24/1
💥 The oC10Sharing1 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35163/20/1
💥 The oC10Files3 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35163/15/1
💥 The oC10RenameFolder tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35163/14/1
💥 The oC10FileFolderOperations tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/35163/12/1
💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the fix-indicators-with-quick-link-action branch from c08941b to a9d7d12 Compare April 26, 2023 08:47
@JammingBen JammingBen changed the title Fix sharing indicators when adding a link via quick action Fix share loading when adding a link via quick action Apr 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.4% 21.4% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen requested review from dschmidt and kulmann April 26, 2023 09:53
@kulmann kulmann merged commit c9c53ab into master Apr 27, 2023
@kulmann kulmann deleted the fix-indicators-with-quick-link-action branch September 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[files-app] Quicklink not displayed after creation [files-app] share indicator icons wrong
3 participants
@JammingBen @ownclouders @kulmann