Show read-only user-attributes as locked #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
added 2 commits
April 20, 2023 03:21
AlexAndBear
commented
Apr 20, 2023
Comment on lines
-14
to
-18
| :label="title" | ||
| :fix-message-line="fixMessageLine" | ||
| :error-message="errorMessage" | ||
| :warning-message="warningMessage" | ||
| :description-message="descriptionMessage" |
There was a problem hiding this comment.
basically I do the same as we do with oc-select and vue-select and bind the $attrs
AlexAndBear
commented
Apr 20, 2023
Comment on lines
-54
to
46
| }, | ||
| disabled: { | ||
| type: Boolean, | ||
| default: false | ||
| }, | ||
|
|
||
| /** | ||
| * Whether or not vertical space below the input should be reserved for a one line message, | ||
| * so that content actually appearing there doesn't shift the layout. | ||
| */ | ||
| fixMessageLine: { | ||
| type: Boolean, | ||
| default: false | ||
| }, | ||
| /** | ||
| * A warning message which is shown below the select. | ||
| */ | ||
| warningMessage: { | ||
| type: String, | ||
| default: null | ||
| }, | ||
| /** | ||
| * An error message which is shown below the select. | ||
| */ | ||
| errorMessage: { | ||
| type: String, | ||
| default: null | ||
| }, | ||
| /** | ||
| * A description text which is shown below the select field. | ||
| */ | ||
| descriptionMessage: { | ||
| type: String, | ||
| default: null | ||
| } |
There was a problem hiding this comment.
These are props of oc-select, we don't need to define them twice =)
JammingBen
approved these changes
Apr 20, 2023
packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue
Outdated
Show resolved
Hide resolved
…ditPanel.vue Co-authored-by: Jannik Stehle <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: