Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzy fuse filter results #8863

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

JammingBen
Copy link
Contributor

Description

We want the Fuse threshold to be 0 to disable any fuzziness. Additionally, ignoreLocation has to be set to true. Otherwise the locations of the search terms would play a role as well (which we don't want). See https://fusejs.io/concepts/scoring-theory.html#scoring-theory for more details.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Apr 19, 2023
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen force-pushed the fix-fuzzy-fuse-filter-results branch from 2e033ee to f601d2b Compare April 19, 2023 12:12
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

68.8% 68.8% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit b1574d9 into master Apr 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-fuzzy-fuse-filter-results branch April 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuse filter does not show results in certain scenarios
2 participants