Fix pagination after increasing items per page #8854
Conversation
JammingBen
force-pushed
the
fix-pagination-after-item-per-page-increase
branch
from
0669deb to
e86f9ec
Compare
| @@ -130,6 +148,21 @@ export default defineComponent({ | |||
| } | |||
| } | |||
|
|
|||
| const setItemsPerPage = (itemsPerPage: string) => { | |||
| const resetPagination = itemsPerPage > unref(itemsPerPageQuery) && unref(currentPage) > 1 | |||
There was a problem hiding this comment.
IMO we should go back to page 1 whenever the items per page change. So not only if the items per page increase, but instead on any change
There was a problem hiding this comment.
I thought we already had this kind of reset in the past. Don't know if it got lost when we moved the pagination params from the store into the composable+query. 🤔 do you know or did you find any orphaned code fragments regarding the page reset?
There was a problem hiding this comment.
IMO we should go back to page 1 whenever the items per page change. So not only if the items per page increase, but instead on any change
Sounds good as well 👍
do you know or did you find any orphaned code fragments regarding the page reset?
I didn't see anything regarding this. Where could such code be located? AFAIK ViewOptions is the only component where we set items-per-page.
| @@ -0,0 +1,6 @@ | |||
| Bugfix: Pagination after increasing items per page | |||
|
|
|||
| An issue where the file list incorrectly showed no items after paginating and increasing the amount of items per page has been fixed. | |||
There was a problem hiding this comment.
| An issue where the file list incorrectly showed no items after paginating and increasing the amount of items per page has been fixed. | |
| An issue where the file list incorrectly showed no items after paginating and changing the amount of items per page has been fixed. |
There was a problem hiding this comment.
Was about to do the same, but the bug report is still right though, no? The issue only occurred when increasing the amount of items.
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
fix-pagination-after-item-per-page-increase
branch
Description
Fixes an issue where the file list incorrectly showed no items after paginating and increasing the amount of items per page. This was achieved by resetting the
pagequery back to1if the user is on a page > 1.Related Issue
Types of changes