Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quicklink icon alignment #8822

Merged
merged 5 commits into from
Apr 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-fix-quicklink-icon-alignment
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Fix quicklink icon alignment

We've fixed the alignment of the quicklink icons.

https://github.com/owncloud/web/pull/8822
https://github.com/owncloud/web/issues/8606
Original file line number Diff line number Diff line change
@@ -72,7 +72,7 @@
class="files-collaborators-collaborator-expiration"
data-testid="recipient-info-expiration-date"
:aria-label="expirationDate"
name="calendar"
name="calendar-event"
fill-type="line"
/>
<span class="oc-invisible-sr" v-text="screenreaderShareExpiration" />
@@ -409,4 +409,7 @@ export default defineComponent({
margin-left: var(--oc-space-medium);
}
}
.files-collaborators-collaborator-expiration {
margin-top: 5px;
lookacat marked this conversation as resolved.
Show resolved Hide resolved
}
</style>
Original file line number Diff line number Diff line change
@@ -92,7 +92,7 @@
<oc-icon
v-if="link.expiration"
v-oc-tooltip="expirationDateTooltip"
class="oc-files-public-link-expires"
class="oc-files-public-link-expires oc-ml-xs"
:data-testid="`files-link-id-${link.id}-expiration-date`"
:aria-label="expirationDateTooltip"
name="calendar-event"
@@ -557,4 +557,8 @@ export default defineComponent({
justify-content: flex-start;
}
}

.oc-files-public-link-expires {
margin-top: 1px; // to align with the other elements
}
</style>