Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add font family to theming #8797

Merged
merged 1 commit into from
Apr 12, 2023
Merged

feat: add font family to theming #8797

merged 1 commit into from
Apr 12, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 12, 2023

Description

Adds a fontFamily token to the designTokens in theming and makes sure that it gets applied to the already existing css variable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Apr 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit f732bf1 into master Apr 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the allow-font-family-in-theming branch April 12, 2023 11:19
ownclouders pushed a commit that referenced this pull request Apr 12, 2023
@kulmann
Merge pull request #8797 from owncloud/allow-font-family-in-theming
dca3034 
feat: add font family to theming
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @JammingBen