Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/8645 - Show tooltip for longs tags in ResourceTable #8794

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Feature/8645 - Show tooltip for longs tags in ResourceTable #8794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog/unreleased/enhancement-tags-support
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ https://github.com/owncloud/web/pull/8157
https://github.com/owncloud/web/pull/8309
https://github.com/owncloud/web/pull/8405
https://github.com/owncloud/web/pull/8502
https://github.com/owncloud/web/pull/8794
https://github.com/owncloud/web/issues/7134
https://github.com/owncloud/web/issues/8149
https://github.com/owncloud/web/issues/8220
https://github.com/owncloud/web/issues/8253
https://github.com/owncloud/web/issues/8254
https://github.com/owncloud/web/issues/8390
https://github.com/owncloud/web/issues/8645
10 changes: 9 additions & 1 deletion packages/web-app-files/src/components/FilesList/ResourceTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@
v-bind="getTagComponentAttrs(tag)"
class="resource-table-tag-wrapper"
>
<oc-tag class="resource-table-tag oc-ml-xs" :rounded="true" size="small">
<oc-tag
v-oc-tooltip="getTagToolTip(tag)"
class="resource-table-tag oc-ml-xs"
:rounded="true"
size="small"
>
<oc-icon name="price-tag-3" size="small" />
<span class="oc-text-truncate">{{ tag }}</span>
</oc-tag>
Expand Down Expand Up @@ -420,7 +425,10 @@ export default defineComponent({
const { actions: renameActions } = useFileActionsRename()
const renameHandler = computed(() => unref(renameActions)[0].handler)

const getTagToolTip = (text: string) => (text.length > 7 ? text : '')

return {
getTagToolTip,
renameActions,
renameHandler,
resourceRouteResolver,
Expand Down