Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e-test] Do not share versions. added test where share receiver does not see file version #8779

Merged
merged 5 commits into from
Apr 11, 2023
Merged

[e2e-test] Do not share versions. added test where share receiver does not see file version #8779

merged 5 commits into from
Apr 11, 2023

Conversation

ScharfViktor
Copy link
Contributor

related owncloud/ocis#5531
Until PR 5531 is in the master -> webCI still red

  • share receiver does not see file version
  • viewer-member of the project space does not see file version
  • editor-member of the project space see file version

@update-docs
Copy link

update-docs bot commented Apr 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor force-pushed the doNotShareVersionChangeE2eTest branch 2 times, most recently from d0bf3b3 to 5143e26 Compare April 5, 2023 12:55
@ownclouders
Copy link
Contributor

ownclouders commented Apr 5, 2023 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/34568/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/folder-alice-2023-4-5-10-46-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/folder-brian-2023-4-5-10-46-57.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/members-of-the-space-can-control-the-versions-of-the-files-alice-2023-4-5-10-55-25.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/members-of-the-space-can-control-the-versions-of-the-files-carol-2023-4-5-10-55-37.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/unstructured-collection-of-testable-space-interactions-alice-2023-4-5-10-52-52.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/unstructured-collection-of-testable-space-interactions-anonymous-2023-4-5-10-53-49.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/34568/tracing/unstructured-collection-of-testable-space-interactions-brian-2023-4-5-10-53-51.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

@ScharfViktor ScharfViktor force-pushed the doNotShareVersionChangeE2eTest branch from 5143e26 to 05206d4 Compare April 5, 2023 20:38
saw-jan
saw-jan reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan
Copy link
Member

saw-jan commented Apr 11, 2023 

> [email protected] build /go/src/github.com/owncloud/ocis/services/idp
> node --openssl-legacy-provider scripts/build.js && rm -f build/service-worker.js

node: bad option: --openssl-legacy-provider
 ELIFECYCLE  Command failed with exit code 9.
make[1]: *** [Makefile:57: pnpm-build] Error 1
make: *** [Makefile:177: ci-node-generate] Error 1
Retries exhausted

Need node v18 to build (generate nodejs) ocis. Like in PR #8774

@saw-jan saw-jan mentioned this pull request Apr 11, 2023
Closed
@ScharfViktor
Copy link
Contributor Author

Need node v18 to build (generate nodejs) ocis. Like in PR #8774

done. thanks

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor requested a review from saw-jan April 11, 2023 06:43
@SagarGi SagarGi mentioned this pull request Apr 11, 2023
Closed
9 tasks
@ScharfViktor ScharfViktor merged commit b98a538 into master Apr 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the doNotShareVersionChangeE2eTest branch April 11, 2023 21:47
@ScharfViktor ScharfViktor mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@micbar micbar Awaiting requested review from micbar

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScharfViktor @ownclouders @saw-jan