Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set variation to brand for preview controls #8758

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: set variation to brand for preview controls #8758

merged 1 commit into from
Mar 30, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 30, 2023

Description

Controls in the preview app were using the default passive variation for buttons but the brand color swatch for the background. With our new contrast colors in color swatches this lead to black on grey in the dark theme.
Fixed by using the proper brand variation for the buttons => brand style background and brand variation for buttons = good contrast again.

Screenshots (if appropriate):

before (buggy)

Screenshot 2023-03-30 at 17 03 04

after (fixed)

Screenshot 2023-03-30 at 16 58 10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested review from lookacat and AlexAndBear March 30, 2023 15:04
@kulmann kulmann self-assigned this Mar 30, 2023
@kulmann kulmann requested a review from JammingBen March 30, 2023 15:04
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit bf24f93 into master Mar 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the preview-controls-colors branch March 30, 2023 15:34
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @AlexAndBear